Add executablePath to options #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
add to index.js const defaultOptions = {
...
headless: true,
puppeteerArgs: [],
puppeteerExecutablePath: undefined,
...
} |
|
@stereobooster Done. |
src/puppeteer_utils.js
Outdated
| @@ -135,6 +135,7 @@ const crawl = async opt => { | |||
| const browser = await puppeteer.launch({ | |||
| headless: options.headless, | |||
| args: options.puppeteerArgs, | |||
| executablePath: options.executablePath, | |||
There was a problem hiding this comment.
executablePath: options.puppeteerExecutablePath
|
I can merge as is, but it would be nice to have some documentation (in caveats section) |
|
What do you think, my English might be poor... |
Readme.md
Outdated
| @@ -97,6 +97,12 @@ Use `inlineCss: true` to enable this feature. | |||
|
|
|||
| TODO: as soon as the feature will be stable it should be enabled by default. | |||
|
|
|||
| ### puppeteerExecutablePath | |||
There was a problem hiding this comment.
Name section Docker and move under Containers and other restricted environments.
|
Thank you. You do not need to be sorry for your english or forgetting something. Any contribution is valuable if it improves functionality. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support #93 , add a single line.