Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bugs for and add features for generic V2 #185

Merged
merged 6 commits into from
Apr 23, 2023

Conversation

r0ngk
Copy link
Contributor

@r0ngk r0ngk commented Apr 20, 2023

Bug fix:

  1. scroll from home use none coordinate
  2. default behaviour of script not specify [bug] Empty combat script leads to crash for GenericV2 #184

Features:

  1. add enable auto in ready page
  2. complete more combat script action from original
  3. custom wait time after clicking a button

r0ngk added 2 commits April 20, 2023 19:45
bug fix:
1. scroll from home use none coordinate
2. default behaviour of script not specify
features:
add enable auto in ready page
complete more combat script action from original
add support to DMM, without the Mobage side bar
@r0ngk
Copy link
Contributor Author

r0ngk commented Apr 21, 2023

fix issues #186

@AthTop
Copy link

AthTop commented Apr 22, 2023

Skill selecting seems to not work. It selects character fine, then clicks between skills 2-3 and goes off to the next command.

@steve1316 steve1316 self-assigned this Apr 22, 2023
@steve1316 steve1316 added bug Something isn't working enhancement New feature or request labels Apr 22, 2023
@steve1316
Copy link
Owner

steve1316 commented Apr 22, 2023

Skill selecting seems to not work. It selects character fine, then clicks between skills 2-3 and goes off to the next command.

@AthTop, just to confirm was this with GenericV2 or was this seen in other Farming Modes?

Also, were you using a second window and roughly where was your main window (the one doing the combat) positioned? Far left of your screen, far right, etc.?

@AthTop
Copy link

AthTop commented Apr 22, 2023

It was with GenericV2 yes.
Main window was on the far left, with sub window being to main window's right side.

@r0ngk
Copy link
Contributor Author

r0ngk commented Apr 23, 2023

Issues is confirmed, working on it

@r0ngk
Copy link
Contributor Author

r0ngk commented Apr 23, 2023

Skill selecting problem solved

Copy link
Owner

@steve1316 steve1316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@steve1316 steve1316 merged commit 96338f0 into steve1316:main Apr 23, 2023
@r0ngk r0ngk deleted the v2_update branch March 31, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants