fix: use --force-exclude
with Ruff
#348
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋, thank you for this plugin!
This PR updates the arguments passed to Ruff to include
--force-exclude
to make exclusions work. To give some context, if theruff
command is invoked with a filename directly then the exclusions from the config file aren't taken into consideration. When--force-exclude
is passed, only then it's used to determine whether to skip runningruff
on the given file or not.From the CLI help menu:
We also use the same when invoking the
ruff
command via the LSP implementation:ruff check
command args: https://github.com/astral-sh/ruff-lsp/blob/145e36dbe62b80f0a5682f25782a7038da9a8621/ruff_lsp/server.py#L158ruff format
command args: https://github.com/astral-sh/ruff-lsp/blob/145e36dbe62b80f0a5682f25782a7038da9a8621/ruff_lsp/server.py#L1918In addition to that, the following changes were made:
check
subcommand as callingruff
via an implicit check command is now deprecated (warning:ruff <path>
is deprecated. Useruff check <path>
instead.).ruff.toml
file to determine the current working directory