-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Composer): update to latest wpcs release #38
Conversation
@stevegrunwell could you please switch the default branch back to |
Yep. I'm totally backed against the wrong branch in my fork due to the branch polarity reversal here. I'm going to push a hack up for now until I hear back before I rebase and update this pull to fix #39 |
git diff --name-only --cached --diff-filter=ACMRTUXB | xargs vendor/bin/phpcs $standard | ||
if [ $? != 0 ] | ||
then | ||
composer run lint:plugin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this command coming from? While it's handy to have a Composer script to run, I don't see a definition for this anywhere (nor is WP Enforcer only used for plugins, as this command seems to indicate).
The branching strategy isn't backwards, it may be just be a bit different than what you're used to (especially if you're typically using a "branch off of master, then merge into staging and/or master to deploy to staging or production, respectively" workflow). As outlined in the contributing doc, new feature branches should come off of develop (which is the primary branch); the only time things are merged to master is when a new release is tagged, and that's by way of a If you're not familiar with this pattern (commonly referred to as "Gitflow"), I'd recommend checking out this documentation from Atlassian. |
Closing this as the WP-CLI generates I'll open a bug for the related change, but I'm pulling back from using |
closes #37
For those who want this now:
EDIT: Probably don't use this until #38 (comment) is addressed.