Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added html_root_url attribute #26

Closed
wants to merge 2 commits into from
Closed

Added html_root_url attribute #26

wants to merge 2 commits into from

Conversation

stanciuadrian
Copy link
Contributor

Should resolve #19

src/lib.rs Outdated
@@ -1,3 +1,5 @@
#![doc(html_root_url = "https://docs.rs/semver-parser/0.7.0")]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason to link to a specific version here?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's no longer needed since... two days ago 😄 rust-lang/api-guidelines@5c457df

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Let's do that then; much cleaner this way 😄

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should close the this issue then? And remove other html_root_url?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@opilar see the discussion here mgeisler/version-sync#27

@steveklabnik
Copy link
Owner

Apparently this is no longer needed. Thanks so much @stanciuadrian, but since it's not in the guideline, I'd prefer to not accept. Thank you!

@lnicola
Copy link

lnicola commented Nov 24, 2017

@steveklabnik It's been re-added in rust-lang/api-guidelines@b36cc0d after the discussion I linked above.

@steveklabnik steveklabnik reopened this Nov 24, 2017
@steveklabnik
Copy link
Owner

Gah, sorry I misunderstood. This is very unfortunate.

@steveklabnik
Copy link
Owner

merged as 4af5bb0, thanks!

@stanciuadrian
Copy link
Contributor Author

You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add html_root_url attribute to crate root
4 participants