-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added html_root_url attribute #26
Conversation
src/lib.rs
Outdated
@@ -1,3 +1,5 @@ | |||
#![doc(html_root_url = "https://docs.rs/semver-parser/0.7.0")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason to link to a specific version here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's no longer needed since... two days ago 😄 rust-lang/api-guidelines@5c457df
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Let's do that then; much cleaner this way 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should close the this issue then? And remove other html_root_url?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@opilar see the discussion here mgeisler/version-sync#27
Apparently this is no longer needed. Thanks so much @stanciuadrian, but since it's not in the guideline, I'd prefer to not accept. Thank you! |
@steveklabnik It's been re-added in rust-lang/api-guidelines@b36cc0d after the discussion I linked above. |
Gah, sorry I misunderstood. This is very unfortunate. |
merged as 4af5bb0, thanks! |
You're welcome! |
Should resolve #19