Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : bold text color + bold highlight color #403

Merged
merged 5 commits into from
Jul 15, 2024
Merged

fix : bold text color + bold highlight color #403

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6db8197
fix: cannot set text color when the text is bold
MODSetter May 28, 2024
21003e7
fix : bold text color + bold highlight color
MODSetter May 28, 2024
4bbb35b
Added comment in prosemirror.css
MODSetter May 28, 2024
2c80c0f
Merge branch 'steven-tey:main' into bold-color-fix
MODSetter May 28, 2024
5ccdaf9
updated docs
MODSetter May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions apps/web/styles/prosemirror.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,4 +200,12 @@ div[data-youtube-video] > iframe {
div[data-youtube-video] > iframe {
max-height: 100px;
}
}

span[style] > strong {
color: inherit;
}

mark[style] > strong {
color: inherit;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey thanks for the change, it would be great if you can also add the changes to the prosemirror docs file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey thanks for the change, it would be great if you can also add the changes to the prosemirror docs file

Can you link the doc file for prosemirror. Can't find anything related to prosemirror at https://github.com/steven-tey/novel/tree/main/apps/docs

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey should be here
https://novel.sh/docs/guides/tailwind/setup#prosemirror-styles
https://github.com/steven-tey/novel/blob/main/apps/docs/guides/tailwind/setup.mdx#add-styles

Copy link
Contributor Author

@MODSetter MODSetter May 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey should be here https://novel.sh/docs/guides/tailwind/setup#prosemirror-styles https://github.com/steven-tey/novel/blob/main/apps/docs/guides/tailwind/setup.mdx#add-styles

Updated the docs 👍

}