Add -Wall and -Wextra, fix lots of warnings #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anything else to be done to have that merged? |
stevengj
reviewed
Apr 11, 2019
- remove set but not used variables - (void) cast unused function arguments - create internal function duplicates for some actually deprecated functions, for the f77 files disable the deprecation warning completely. - add warning flags to travis Note: some of the maybe-unitialized warnings do not show in gcc 7.3.0, but travis seems to use a different one. This closes #226.
|
rebased and updated to eliminate internal usage of the deprecated API |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deprecated functions, for the f77 files disable
the deprecation warning completely.
Note: some of the maybe-unitialized warnings do not
show in gcc 7.3.0, but travis seems to use a different one.
This closes #226.