Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move away from deprecated interfaces #29

Merged
merged 3 commits into from
Dec 5, 2020

Conversation

fpicalausa
Copy link
Contributor

Use the newer (non-deprecated) token builder methods to build the id_token.

@steverhoades
Copy link
Owner

@fpicalausa Thanks for the contribution. Can you please include the minimum version of the oauth2-server this change is compatible with?

@fpicalausa
Copy link
Contributor Author

@fpicalausa Thanks for the contribution. Can you please include the minimum version of the oauth2-server this change is compatible with?

@steverhoades Thanks for building this library! It's been really useful.

The deprecation is actually occuring in lcobucci/jwt, starting with version 3.3 in preparation for moving to 4.0.
I checked oauth2-server for compatibility, as well:

  • 5.1 and 6.0 both require lcobucci/jwt=^3.1.
  • 7.0 should be requires lcobucci/jwt=^3.2.2.
  • 8.0 should be requires lcobucci/jwt=^3.3.1.

From the version range, I think requiring lcobucci/jwt=^3.3 should be safe, but let me know if there are other things we should check first.

@steverhoades
Copy link
Owner

@fpicalausa Thanks for that, since this is a breaking change I'll need to update the major version of this library. When you get an opportunity could you update the Readme to indicate the new minimum version requirements?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants