Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IdTokenResponse.php #54

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Conversation

xterr
Copy link
Contributor

@xterr xterr commented Aug 29, 2023

Currently there is a bug in which the default claims are not set. This happens because all the claim set operations are returning a new instance instead of setting the value on the current object

Currently there is a bug in which the default claims are not set. This happens because all the claim set operations are returning a new instance instead of setting the value on the current object
Copy link

@ro0NL ro0NL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can confirm this fixes our openid login

please merge :)

cc @steverhoades

@ro0NL
Copy link

ro0NL commented Sep 8, 2023

cc @steverhoades

@steverhoades steverhoades merged commit 269c4dc into steverhoades:master Sep 8, 2023
@steverhoades
Copy link
Owner

Released as v2.6.1. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants