fix: stat diff summary performance #982
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating why running git log was taking so long for a repo (it's pretty large and there was some mass renaming). There was one commit (~4000 changed files) that was taking ~19s to parse the diff summary for and overall it would take ~40s. When running the equivalent native git command it only took ~8s.
Looking into it a bit more, I believe the main cause was that the regex is doing a lot of backtracking, especially for long filenames. So my fix was to just add
^
to make it match from the start of the line and avoid some backtracking.Before:
After: