Fix sync_file_range() with musl 1.2.4 #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musl 1.2.4 has removed the transitional LFS off64_t type. sync_file_range is declared with off_t in musl, which is always 64 bits. This assumes that the same is true of any other libc which doesn't provide off64_t. If it's not, gcc will produce an error due to the conflicting types of sync_file_range(), so it will be caught and can be fixed.
13 tasks
alyssais
added a commit
to alyssais/nixpkgs
that referenced
this pull request
May 13, 2024
This reverts commit c7f51f0. This broke 32-bit Glibc builds. I've submitted a revised patch upstream, but in the meantime, there's no point keeping this around, since we didn't do the musl upgrade yet. Link: NixOS#292654 (comment) Link: stewartsmith/libeatmydata#36
This was referenced May 13, 2024
alyssais
added a commit
to NixOS/nixpkgs
that referenced
this pull request
May 13, 2024
This reverts commit c7f51f0. This broke 32-bit Glibc builds. I've submitted a revised patch upstream, but in the meantime, there's no point keeping this around, since we didn't do the musl upgrade yet. Link: #292654 (comment) Link: stewartsmith/libeatmydata#36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
musl 1.2.4 has removed the transitional LFS off64_t type. sync_file_range is declared with off_t in musl, which is always 64 bits.
This assumes that the same is true of any other libc which doesn't provide off64_t. If it's not, gcc will produce an error due to the conflicting types of sync_file_range(), so it will be caught and can be fixed.