Fix bugs in Goal and GoalGroup equality testing #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- as an unmet goal and a met goal should never be equal
gregcorbett
force-pushed
the
goal_equality_bug_fix
branch
from
35a7fb8 to
2d5b4a9
Compare
- split is_equal_to into two submethods - add a helper function to count the occurrences of a Goal in a GoalGroup
gregcorbett
force-pushed
the
goal_equality_bug_fix
branch
from
2d5b4a9 to
780b89f
Compare
|
codeclimate issues detected are outside of the scope of this PR. They have been tracked in #29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds unit tests for the Goal and GoalGroup equality checks.