Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops support for ASE < 3.23, due to substantial API changes.
See similar required changes: stfc/janus-core#181
I think the only unresolved test is
tests/calculations/test_singlepoint.py
, which I believe is the same as #135.I think it might make sense to fix that here, rather than in #136, as the test passes with ASE 3.22.1.
I think the root isn't the file extension, but instead the change that I mention in stfc/janus-core#181: it appears that with the new ASE, results are no longer saved in
Atoms.arrays
, which means that when you setresults = convert_numpy(content.todict())
, the results are not present.However, without any file extension/format changes, the results are still there in the
calc.results
dictionary, and with @alinelena's changes, they will be in theAtoms.info
dictionary shortly, so I think using those is the required fix, @federicazanca.