Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ASE #137

Closed
wants to merge 2 commits into from
Closed

Update ASE #137

wants to merge 2 commits into from

Conversation

ElliottKasoar
Copy link
Member

@ElliottKasoar ElliottKasoar commented Jun 4, 2024

Drops support for ASE < 3.23, due to substantial API changes.

See similar required changes: stfc/janus-core#181

I think the only unresolved test is tests/calculations/test_singlepoint.py, which I believe is the same as #135.

I think it might make sense to fix that here, rather than in #136, as the test passes with ASE 3.22.1.

I think the root isn't the file extension, but instead the change that I mention in stfc/janus-core#181: it appears that with the new ASE, results are no longer saved in Atoms.arrays, which means that when you set results = convert_numpy(content.todict()), the results are not present.

However, without any file extension/format changes, the results are still there in the calc.results dictionary, and with @alinelena's changes, they will be in the Atoms.info dictionary shortly, so I think using those is the required fix, @federicazanca.

@ElliottKasoar ElliottKasoar added bug Something isn't working aiida-mlip labels Jun 4, 2024
@ElliottKasoar
Copy link
Member Author

ElliottKasoar commented Jun 5, 2024

There’s a chance it’s not broken yet, but we probably ought to update janus at the same time, given that the API changes to ASE mean some parts are incompatible otherwise.

Then the last test errors are hopefully just making sure it properly reads the data that is saved slightly differently now, which should also fix the issue as mentioned above.

@alinelena
Copy link
Member

included in !pr 136

@alinelena alinelena closed this Jun 5, 2024
@ElliottKasoar ElliottKasoar deleted the update-ase branch October 17, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants