Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split Fortran2008.py into one file per class #411

Closed
rupertford opened this issue Apr 30, 2023 · 5 comments
Closed

split Fortran2008.py into one file per class #411

rupertford opened this issue Apr 30, 2023 · 5 comments
Assignees

Comments

@rupertford
Copy link
Collaborator

The Fortran2008.py file is getting large and it would be better to have a Fortran2008 directory containing a separate file for each class with an init that imports all of the files. There may be an issue with the class generation and class hierarchy generation.

@rupertford
Copy link
Collaborator Author

I tested this out in https://github.com/stfc/fparser/tree/split_f2008_file and have got it to work. I'll wait until #408 is on master before progressing this.

@rupertford rupertford self-assigned this Apr 30, 2023
@rupertford
Copy link
Collaborator Author

I'll create a Fortran2008 directory containing an init file and move the Fortran2008.py file into this directory first before splitting out the classes as I also need to move the class generation code into the init file and update the logic that calls this.

@rupertford
Copy link
Collaborator Author

Created branch 411_move_fortran2008_file

rupertford added a commit that referenced this issue May 19, 2023
arporter added a commit that referenced this issue Jun 12, 2023
use __init__ to import Fortran2008 classes (towards #411)
@rupertford
Copy link
Collaborator Author

Now that #417 is on master I can split the Fortran2008.py file into one file per class.

@rupertford
Copy link
Collaborator Author

Created branch 411_split_file

rupertford added a commit that referenced this issue Jul 9, 2023
rupertford added a commit that referenced this issue Aug 3, 2023
arporter added a commit that referenced this issue Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant