Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue #171. Removal of statement function matching. #200

Merged
merged 9 commits into from
Jul 3, 2019
Merged

issue #171. Removal of statement function matching. #200

merged 9 commits into from
Jul 3, 2019

Conversation

rupertford
Copy link
Collaborator

No description provided.

@rupertford rupertford self-assigned this May 30, 2019
@codecov-io
Copy link

codecov-io commented May 31, 2019 •
edited
Loading

Codecov Report

Merging #200 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
- Coverage   89.83%   89.76%   -0.07%     
==========================================
  Files          34       34              
  Lines       11930    11931       +1     
==========================================
- Hits        10717    10710       -7     
- Misses       1213     1221       +8
Impacted Files Coverage Δ
src/fparser/scripts/script_options.py 100% <ø> (ø) ⬆️
src/fparser/two/Fortran2008.py 100% <ø> (ø) ⬆️
src/fparser/scripts/fparser2.py 100% <100%> (ø) ⬆️
src/fparser/two/Fortran2003.py 92.09% <100%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d02e2b8...28044b0. Read the comment docs.

@rupertford rupertford requested a review from arporter June 2, 2019 22:09
@rupertford
Copy link
Collaborator Author

Ready for 1st review from @arporter.

arporter
arporter requested changes Jun 6, 2019
View reviewed changes
Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very little to say - just a few tiny issues to fix.

New code is covered.
Documentation doesn't need updating.
Changes are pylint clean.
There are no references to this issue within the code.

src/fparser/scripts/fparser2.py Show resolved Hide resolved
src/fparser/two/tests/fortran2003/test_declaration_construct_r207.py Outdated Show resolved Hide resolved
src/fparser/two/tests/fortran2003/test_declaration_construct_r207.py Outdated Show resolved Hide resolved
src/fparser/scripts/fparser2.py Show resolved Hide resolved
@arporter arporter added reviewed with actions PR has been reviewed and is back with developer and removed under review labels Jun 6, 2019
@arporter arporter mentioned this pull request Jun 6, 2019
Merged
@rupertford rupertford mentioned this pull request Jun 26, 2019
Merged
@rupertford
Copy link
Collaborator Author

Ready for next review from @arporter

@rupertford rupertford added ready for review and removed reviewed with actions PR has been reviewed and is back with developer labels Jun 27, 2019
@arporter
Copy link
Member

All requested changes have been made.
Contrary to what I said last time, I think we should document the fact that we've turned off support for Statement Functions. Please could you update the documentation appropriately and then this can be merged.

@arporter arporter added reviewed with actions PR has been reviewed and is back with developer and removed ready for review labels Jun 28, 2019
@rupertford
Copy link
Collaborator Author

You are quite right about documentation. I have added some words. Hopefully they clarify. Ready for next review from @arporter

@rupertford rupertford added ready for review and removed reviewed with actions PR has been reviewed and is back with developer labels Jul 2, 2019
@arporter
Copy link
Member

arporter commented Jul 3, 2019

New documentation is good - thanks!

@arporter arporter merged commit 8a53476 into master Jul 3, 2019
@arporter arporter deleted the sergi_sf_hack branch July 3, 2019 08:44
@rupertford rupertford mentioned this pull request Jul 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arporter arporter arporter approved these changes

Assignees

@rupertford rupertford

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rupertford @codecov-io @arporter