Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix namelist r552 matching error (closes #165) #415

Merged
merged 4 commits into from
May 15, 2023
Merged

Conversation

rupertford
Copy link
Collaborator

The implementation of namelist-stmt r552 in Fortran2003 (Namelist_Stmt) contained asserts in two places rather than returning None (which specifies no match). This PR fixes this error, tidies the code, tightens the implementation and adds tests that fully cover the code in the class.

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (fbcc2c6) 91.75% compared to head (a0d8253) 91.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #415   +/-   ##
=======================================
  Coverage   91.75%   91.76%           
=======================================
  Files          37       37           
  Lines       13384    13387    +3     
=======================================
+ Hits        12281    12284    +3     
  Misses       1103     1103           
Impacted Files Coverage Δ
src/fparser/two/Fortran2003.py 94.41% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rupertford
Copy link
Collaborator Author

Ready for first review from @arporter or @sergisiso

Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Changes are pylint clean.
Coverage is all good.
This is a bug fix so no documentation update required.
Issue number is not mentioned anywhere.
Will proceed to merge.

@arporter arporter added ready for merge PR is waiting on final CI checks before being merged. and removed under review labels May 15, 2023
@arporter arporter merged commit 0d802aa into master May 15, 2023
@arporter arporter deleted the 165_namelist_error branch May 15, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ready for merge PR is waiting on final CI checks before being merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants