Load git repo from projectDir instead of current working directory #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the gradle project using the gitrelease plugin is not accessed from the command line inside the gradle project it fails with an exception as it cannot figure out what the git repository is. This fix uses the projects projectDir as a starting point in finding the git repository. This might cause issues if someone relied on this feature and used the gitrelease plugin without having the working directory being the projects checked out git repository. This fix allows gradle projects using the gitrelease to be imported into IntelliJ directly with the built-in gradle support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the gradle project using the gitrelease plugin is not accessed from the
command line inside the gradle project it fails with an exception as it
cannot figure out what the git repository is.
This fix uses the projects projectDir as a starting point in finding the
git repository. This might cause issues if someone relied on this feature
and used the gitrelease plugin without having the working directory being
the projects checked out git repository.
This fix allows gradle projects using the gitrelease to be imported
into IntelliJ directly with the built-in gradle support.