Update GH action #121
Merged
Update GH action #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actions/setup-ruby is deprecated and should be replaced with the maintained ruby/setup-ruby
|
Thanks a ton 👏 |
|
Ah, forgot that with setup-ruby you have to specify the complete ruby version... could you do that? I think 3.0.3 should be fine! |
|
Using... - uses: ruby/setup-ruby@v1
with:
ruby-version: 3.0.3
bundler-cache: trueCould both install ruby 3 and cache gems. Thus reducing next action as well :) |
as recommended
nachiket87
commented
Dec 3, 2021
| @@ -19,12 +19,6 @@ jobs: | |||
| with: | |||
| ruby-version: 3.0.3 | |||
| bundler-cache: true | |||
| - uses: actions/cache@v1 | |||
| with: | |||
| path: vendor/bundle | |||
There was a problem hiding this comment.
@rickychilcott Is this okay?
There was a problem hiding this comment.
Seems right to me! Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR (feature, enhancement, bug fix, etc.)
Enhancement.
Description
actions/setup-ruby is deprecated and should be replaced with the maintained ruby/setup-ruby
Keep GH actions updated and remove deprecated dependencies.
Checklist