This repository has been archived by the owner on Jul 3, 2023. It is now read-only.
Touches up the package settings #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. We were not adding the license to the package. 2. This adds a few optional fields that will be useful to have.
elijahbenizzy
approved these changes
Oct 13, 2021
| @@ -81,5 +83,11 @@ def load_test_requirements(): | |||
|
|
|||
| # Note that this feature requires pep8 >= v9 and a version of setup tools greater than the | |||
| # default version installed with virtualenv. Make sure to update your tools! | |||
| python_requires='>=3.6', | |||
| python_requires='>=3.6, <4', | |||
There was a problem hiding this comment.
Is this by convention? Not sure we're going to get a python 4.. https://www.techrepublic.com/article/programming-languages-why-python-4-0-will-probably-never-arrive-according-to-its-creator/
There was a problem hiding this comment.
It was in the python example package. So I thought, sure, why not.
This check will ensure we have uniform formatting in the repo. Otherwise we should depend on circleci images to run the actual tests.
We somehow checked in a few things without it adhering to our formatting style guide for the repo. This fixes that.
So that we can push this package into the wild!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Short description explaining the high-level reason for the pull request]
Additions
Removals
N/A
Changes
N/A
Testing
Screenshots
N/A
Notes
N/A
Todos
N/A
Checklist
Testing checklist
Python