Skip to content
This repository has been archived by the owner on Jul 3, 2023. It is now read-only.

Fixes mistaken superclass call #177

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Fixes mistaken superclass call #177

merged 1 commit into from
Aug 15, 2022

Conversation

elijahbenizzy
Copy link
Collaborator

@elijahbenizzy elijahbenizzy commented Aug 11, 2022

[Short description explaining the high-level reason for the pull request]

Changes

Testing

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Python - local testing

  • python 3.6
  • python 3.7

This removes the ability to add coroutines as inputs. It was flaky,
and suboptimal. If we want to do that we can do it later, but for
now pure data has to be passed in. Note that this was never released
(and never worked), and is experimental, so we can happily remove this
without a major bump.
@elijahbenizzy elijahbenizzy marked this pull request as ready for review August 14, 2022 19:13
@elijahbenizzy elijahbenizzy merged commit 957c73a into main Aug 15, 2022
@elijahbenizzy elijahbenizzy deleted the async-fix branch August 15, 2022 01:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant