This repository has been archived by the owner on Jul 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 37
Demonstrates duckdb adapters + data loaders #195
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijahbenizzy
force-pushed
the
db-integrations
branch
3 times, most recently
from
September 15, 2022 03:50
12c12cc
to
afa3810
Compare
skrawcz
reviewed
Sep 23, 2022
elijahbenizzy
force-pushed
the
db-integrations
branch
3 times, most recently
from
September 26, 2022 18:06
275cb54
to
ba74364
Compare
elijahbenizzy
force-pushed
the
db-integrations
branch
from
September 26, 2022 18:18
ba74364
to
ca686c9
Compare
skrawcz
reviewed
Sep 26, 2022
elijahbenizzy
force-pushed
the
db-integrations
branch
from
September 26, 2022 18:49
ca686c9
to
3e213a1
Compare
skrawcz
reviewed
Sep 27, 2022
skrawcz
reviewed
Sep 27, 2022
elijahbenizzy
force-pushed
the
db-integrations
branch
2 times, most recently
from
September 27, 2022 20:30
604763f
to
ab20a05
Compare
We still want built-in adapters, but for now this will work.
elijahbenizzy
force-pushed
the
db-integrations
branch
from
September 27, 2022 21:03
ab20a05
to
5e14b48
Compare
skrawcz
reviewed
Sep 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also should remove the database.duckdb file?
Nope we deleted the generator so it has to be there. We load from it. |
skrawcz
approved these changes
Jan 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Short description explaining the high-level reason for the pull request]
Changes
Testing
Notes
Checklist
Testing checklist
Python - local testing