Skip to content
This repository has been archived by the owner on Jul 3, 2023. It is now read-only.

Uses fixed instead of relative import for async example #204

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

elijahbenizzy
Copy link
Collaborator

The relative import was sloppy, and not best practices.

[Short description explaining the high-level reason for the pull request]

Changes

Testing

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Python - local testing

  • python 3.6
  • python 3.7

The relative import was sloppy, and not best practices.
@elijahbenizzy elijahbenizzy marked this pull request as ready for review October 10, 2022 05:16
@elijahbenizzy elijahbenizzy merged commit 321a1b6 into main Oct 10, 2022
@elijahbenizzy elijahbenizzy deleted the fix-async-relative-import branch October 10, 2022 17:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants