Skip to content
This repository has been archived by the owner on Jul 3, 2023. It is now read-only.

Adjusts index type check warnings #246

Merged
merged 2 commits into from
Dec 19, 2022
Merged

Adjusts index type check warnings #246

merged 2 commits into from
Dec 19, 2022

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Dec 14, 2022

Following #243 we need to adjust the warning
to make sense. Since we are not in danger of things breaking imminently. So the warning is just there for the user now to indicate how Pandas might be resolving indexes to create the dataframe.

Changes

How I tested this

  • locally.

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Following #243 we need to adjust the warning
to make sense. Since we are not in danger of things
breaking imminently. So the warning is just there for
the user now to indicate how Pandas might be resolving
indexes to create the dataframe.
This message was just wrong with the count displayed.
So fixing it to reflect how many no index outputs there
actually are.
@skrawcz
Copy link
Collaborator Author

skrawcz commented Dec 14, 2022

@ianhoffman I think this should do the trick.

@skrawcz skrawcz merged commit 83f73ed into main Dec 19, 2022
@skrawcz skrawcz deleted the adjust_warning branch December 19, 2022 00:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant