Skip to content
This repository has been archived by the owner on Jul 3, 2023. It is now read-only.

Migrate documentation from gitbooks to readthedocs #270

Merged
merged 13 commits into from
Jan 31, 2023

Conversation

frenchfrywpepper
Copy link
Contributor

@frenchfrywpepper frenchfrywpepper commented Jan 10, 2023

Issue #69

  • Scope what's required to set up read the docs
  • Create a readthedocs account for the https://github.com/stitchfix/hamilton repo, add multiple administrators
  • Enable build on merge to main, this will be published as the 'latest' documentation version
  • Create some configuration in the docs folder to tell read the docs how to behave
  • Create some configuration in the docs folder to use sphinx/rst/furo theme, etc
  • Move the .md files from the documentation branch and reconfigure them as .rst
  • Determine how it would function and be rebuilt.
  • Read the docs will automatically build on merge to main, and publish as latest
  • If you want to add another 'version' you can activate a new version in the read the docs settings for the project, this can be done by branch or tag
  • If you don't want to build 'latest' from main you can turn that off
  • Get something set up -- determine styling.
  • In this PR I have something setup and working, with minimal style. It's building "hamilton-temp" documentation from my fork.
  • You can see the 'readthedocs' version here: https://hamilton-temp.readthedocs.io/en/readthedocs/
  • You can see the 'latest' version here: https://hamilton-temp.readthedocs.io/en/latest/index.html
  • I've created placeholder pages for all of the current docs, this is to ensure the TOC is working as desired
  • Only the intro page has content and links and such, if we like this direction the next step would be to convert more pages to rst
  • This setup is using the furo theme, further customization is possible, but I'd recommend getting all of the content moved over first.
  • Plan migration from gitbooks.
  • Get all the content moved over to rst on the 'main' branch of hamilton
  • Setup all of the versions to be built
  • Turn off gitbooks?
  • Delete 'documentation' branch

Changes

Creates a docs folder which will replace the 'documentation' branch. Docs folder is configuration for readthedocs with sphinx.

How I tested this

By setting up a hamilton-temp readthedocs project: file:///Users/sarahhaskins/dev/frenchfrywpepper/hamilton/docs/_build/html/index.html

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Issue stitchfix#69

- [] Scope what's required to set up read the docs
- Create a readthedocs account for the https://github.com/stitchfix/hamilton repo, add multiple administrators
- Enable build on merge to main, this will be published as the 'latest' documentation version
- Create some configuration in the docs folder to tell read the docs how to behave
- Create some configuration in the docs folder to use sphinx/rst/furo theme, etc
- Move the .md files from the documentation branch and reconfigure them as .rst
- [] Determine how it would function and be rebuilt.
- Read the docs will automatically build on merge to main, and publish as latest
- If you want to add another 'version' you can activate a new version in the read the docs settings for the project, this can be done by branch or tag
- If you don't want to build 'latest' from main you can turn that off
- [] Get something set up -- determine styling.
- In this PR I have something setup and working, with minimal style. It's building "hamilton-temp" documentation from my fork.
- You can see the 'readthedocs' version here: https://hamilton-temp.readthedocs.io/en/readthedocs/
- You can see the 'latest' version here: https://hamilton-temp.readthedocs.io/en/latest/index.html
- I've created placeholder pages for all of the current docs, this is to ensure the TOC is working as desired
- Only the intro page has content and links and such, if we like this direction the next step would be to convert more pages to rst
- This setup is using the furo theme, further customization is possible, but I'd recommend getting all of the content moved over first.
- [] Plan migration from gitbooks.
- Get all the content moved over to rst on the 'main' branch of hamilton
- Setup all of the versions to be built
- Turn off gitbooks?
- Delete 'documentation' branch
@frenchfrywpepper frenchfrywpepper marked this pull request as draft January 10, 2023 17:43
setup.py Outdated Show resolved Hide resolved
@skrawcz
Copy link
Collaborator

skrawcz commented Jan 11, 2023

@elijahbenizzy
Copy link
Collaborator

These look 🔥

@elijahbenizzy
Copy link
Collaborator

Fo migrating we should just have gitbooks have one page that links to RTD?

@frenchfrywpepper frenchfrywpepper changed the title WIP: Migrate documentation from gitbooks to readthedocs Migrate documentation from gitbooks to readthedocs Jan 26, 2023
@frenchfrywpepper frenchfrywpepper marked this pull request as ready for review January 26, 2023 21:08
@skrawcz
Copy link
Collaborator

skrawcz commented Jan 28, 2023

Thanks @frenchfrywpepper! What's the best way to review this? Should we schedule some time? or?

@frenchfrywpepper
Copy link
Contributor Author

@skrawcz If you want to schedule time, that's fine. Otherwise, it's best just to look at the output: https://hamilton-temp.readthedocs.io/en/readthedocs/

.readthedocs.yaml Outdated Show resolved Hide resolved
@skrawcz
Copy link
Collaborator

skrawcz commented Jan 31, 2023

follow up:

  • add icon logo
  • how to not hardcode links

To go live:

  • merge this (no harm)
  • give the site a walk through / update anything that's stale
  • ask for feedback
  • switch links
  • create redirect

@skrawcz skrawcz merged commit 7e8463c into stitchfix:main Jan 31, 2023
@skrawcz skrawcz mentioned this pull request Jan 31, 2023
7 tasks
@skrawcz skrawcz linked an issue Jan 31, 2023 that may be closed by this pull request
4 tasks
@skrawcz skrawcz mentioned this pull request Jan 31, 2023
@CharityKithaka
Copy link
Contributor

CharityKithaka commented Feb 12, 2023

Hey, @skrawcz . I had a question. I am writing about how they can not hardcode links in the docs folder or am also replacing the hardcoded links in the reST docs folder in the project. Or am doing both?

@skrawcz
Copy link
Collaborator

skrawcz commented Feb 12, 2023

Hey, @skrawcz . I had a question. I am writing about how they can not hardcode links in the docs folder or am also replacing the hardcoded links in the reST docs folder in the project. Or am doing both?

The latter, so replacing hardcoded links in the reST docs folder would be the task please :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redo documentation setup
4 participants