This repository has been archived by the owner on Jul 3, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I pretty much verbatim copied the code from this notebook. It does have a few odd quirks in it -- so if I understood what was going on I removed it, else I left it in. E.g.
test_2
is not used...This is an example that shows:
There are a few other ways one could write some of this code. But as a first pass this seems fine. E.g. we could split up the model training function a bit more. Or we could use the parameterize decorator.
No unit tests have been added, or data quality checks.
Changes
How I tested this
Notes
Checklist