Skip to content
This repository has been archived by the owner on Jul 3, 2023. It is now read-only.

Subdag decorator #317

Merged
merged 1 commit into from
Feb 18, 2023
Merged

Subdag decorator #317

merged 1 commit into from
Feb 18, 2023

Conversation

elijahbenizzy
Copy link
Collaborator

@elijahbenizzy elijahbenizzy commented Feb 18, 2023 •
edited
Loading

Makes @subdag usable. Things to think about/fix:

  • Doesn't work with extract_column, might want to fix
  • Docs need a bit of love
  • Should the load_from parameter be a param or a list of inputs?

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@elijahbenizzy elijahbenizzy changed the base branch from main to target-decorator February 18, 2023 03:15
skrawcz
skrawcz suggested changes Feb 18, 2023
View reviewed changes
decorators.md Outdated Show resolved Hide resolved
decorators.md Outdated Show resolved Hide resolved
decorators.md Outdated Show resolved Hide resolved
decorators.md Outdated Show resolved Hide resolved
examples/reusing_functions/reusable_subdags.py Outdated Show resolved Hide resolved
hamilton/function_modifiers/recursive.py Outdated Show resolved Hide resolved
hamilton/storage/loader.py Outdated Show resolved Hide resolved
tests/resources/reuse_subdag.py Show resolved Hide resolved
skrawcz
skrawcz reviewed Feb 18, 2023
View reviewed changes
decorators.md Show resolved Hide resolved
@elijahbenizzy elijahbenizzy force-pushed the subdag-decorator branch 3 times, most recently from 79ac476 to d8030aa Compare February 18, 2023 21:34
@elijahbenizzy
Implements cleaner spec of reuse_functions, moves and renames
dfb01e4 
This is a log nicer. See discussion here for full context:
#86.
skrawcz
skrawcz approved these changes Feb 18, 2023
View reviewed changes
Copy link
Collaborator

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work. Looks good to go.

@elijahbenizzy elijahbenizzy marked this pull request as ready for review February 18, 2023 23:45
@elijahbenizzy elijahbenizzy merged commit 77712ec into target-decorator Feb 18, 2023
@elijahbenizzy elijahbenizzy deleted the subdag-decorator branch February 18, 2023 23:46
@elijahbenizzy elijahbenizzy mentioned this pull request Feb 20, 2023
Closed
12 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@skrawcz skrawcz skrawcz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elijahbenizzy @skrawcz