This repository has been archived by the owner on Jul 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 37
Here's a numpy example from a numpy tutorial on doing AQI #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://github.com/numpy/numpy-tutorials/tree/main/content for where this is pulled from. The names of the functions could be better I think. Otherwise this doesn't seem like a bad pipeline. Versus doing this analysis in a notebook, the strength of Hamilton here is in forcing concise definitions and language around steps in the analysis -- and then magically the analysis is pretty reusable / very easy to augment. E.g. add some @config.when or split things into python modules to be swapped out.
skrawcz
force-pushed
the
examples/numpy
branch
from
February 16, 2022 01:43
36b8838
to
c95c929
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I think this is actually a great use for validators on the shape of the data, given that typing is just np.ndarray
Hopefully that makes the example clearer.
Adding some end-to-end tests could be nice -- this could be an integration test |
elijahbenizzy
approved these changes
Mar 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/numpy/numpy-tutorials/tree/main/content
for where this is pulled from.
The names of the functions could be better I think. Otherwise this
doesn't seem like a bad pipeline. Versus doing this analysis in a notebook,
the strength of Hamilton here is in forcing concise definitions and language
around steps in the analysis -- and then magically the analysis is pretty
reusable / very easy to augment.
E.g. add some @config.when or split things into python modules to be swapped out.
Additions
Removals
Changes
Testing
python run_analysis.py
Notes
Checklist
Testing checklist
Python
- [ ] python 3.6