Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binding-hs: add haddock documentation #3

Merged
merged 1 commit into from
Jun 12, 2018

Conversation

KiaraGrouwstra
Copy link

No description provided.

@KiaraGrouwstra
Copy link
Author

This was an attempt to port over openai#64, as requested. The Haddock comments largely overlapped though, so not much remained of that after resolving the conflicts. Ironically, it seems all that remained was instead some formatting edits automatically made by stylish-haskell. Feel free to close.

@stites
Copy link
Owner

stites commented Jun 5, 2018

Well, there are some minor doc bumps to add here -- I'm just sort of against the unicode characters because I like the idea of collaborators being able to type things out instead of c/p characters to make a contribution (Something I've had to do a couple of times). That said, I don't mind unicode in docs for math symbols.

Is it possible to add some project-level defaults to stylish-haskell to exclude the unicode? If so I would be happy to merge this.

@KiaraGrouwstra
Copy link
Author

here's a modest version, without the unicode.
background: not doing unicode was actually the default in stylish-haskell. I didn't type unicode myself (or copy-paste), and regular arrows would still work.
I just kind of had it on so as to automatically clean up after me, so I hadn't even noticed it'd done that here originally. :)

@stites stites merged commit cdd1baa into stites:master Jun 12, 2018
@KiaraGrouwstra KiaraGrouwstra deleted the hs-haddock branch June 12, 2018 17:56
@KiaraGrouwstra KiaraGrouwstra restored the hs-haddock branch September 14, 2018 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants