Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent group deletion for groups referenced in AutoGroups configuration #34

Merged
merged 9 commits into from
May 5, 2020

Conversation

stjosh
Copy link
Owner

@stjosh stjosh commented May 5, 2020

Closes #28

@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #34 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##              master       #34   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity        15        17    +2     
===========================================
  Files              5         5           
  Lines             49        58    +9     
===========================================
+ Hits              49        58    +9     
Flag Coverage Δ Complexity Δ
#master 100.00% <100.00%> (ø) 17.00 <12.00> (+2.00)
#stable18 100.00% <100.00%> (ø) 17.00 <12.00> (+2.00)
Impacted Files Coverage Δ Complexity Δ
lib/AutoGroupsManager.php 100.00% <100.00%> (ø) 12.00 <12.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7294297...2af887e. Read the comment docs.

@stjosh stjosh merged commit 0e52fd9 into master May 5, 2020
@stjosh stjosh deleted the handle-group-deletion branch May 5, 2020 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle group deletion
1 participant