Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update README.md. #8

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

peterhuene
Copy link
Contributor

@peterhuene peterhuene commented Oct 21, 2024

Fixes a few formatting issues.

Removes mention of having to manually install sprocket.

Adds information about the checkForUpdates configuration option.

Fixes a few formatting issues.

Removes mention of having to manually install `sprocket`.

Adds information about the `checkForUpdates` configuration option.
README.md Outdated Show resolved Hide resolved
Co-authored-by: Andrew Frantz <andrew.frantz@stjude.org>
@peterhuene peterhuene requested a review from a-frantz October 21, 2024 18:28
- **Document and workspace diagnostics** courtesy of the language server protocol
implementation provided by`sprocket analyzer`.
grammar](https://macromates.com/manual/en/language_grammars). _This grammar
is slated to drive GitHub's syntax highlighting for WDL files [in a future release](https://github.com/github-linguist/linguist/pull/6972)_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any info on when this will actually hit production? The current syntax highlighting is really lousy. Just completely breaks on Bash heredocs which we use somewhat often.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if GitHub publishes what version of linguist they're using in production, but the WDL changes made it into 8.0.0.

@peterhuene peterhuene merged commit bd7ca7a into stjude-rust-labs:main Oct 22, 2024
1 check passed
@peterhuene peterhuene deleted the update-readme branch October 22, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants