Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for effect allele not showing in coefficients table when one snp is analyzed #2407

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

gavrielm
Copy link
Collaborator

@gavrielm gavrielm commented Nov 20, 2024

Description

In snplst regression, effect allele will not show in coefficients table when one snp is analyzed, but will show when >1 snp is analyzed. This PR fixes the issue by matching independent tws using snp id before using term id/name.

Also improved the rendering code for effect allele/refGrp in coefficients table.

Checklist

Check each task that has been performed or verified to be not applicable.

  • Tests: added and/or passed unit and integration tests, or N/A
  • Todos: commented or documented, or N/A
  • Notable Changes: updated release.txt, prefixed a commit message with "fix:" or "feat:", added to an internal tracking document, or N/A

@xzhou82 xzhou82 merged commit a18ede2 into master Nov 20, 2024
3 checks passed
@xzhou82 xzhou82 deleted the fix-effAle-render branch November 20, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants