Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating for C++17 #80

Merged
merged 3 commits into from
May 12, 2021
Merged

Updating for C++17 #80

merged 3 commits into from
May 12, 2021

Conversation

sean-parent
Copy link
Member

  • Minimum requirement now C++14, supports C++17
  • added adobe::invoke_result_t to polyfill C++17
  • added adobe::construct_at() to polyfill C++20
  • deprecated adobe::construct() -> use adobe::construct_at()
  • Removed std::binary_operation and std::unary_operation
  • Updated to boost 1.76.0
  • Fixed section divider comments to all be 100 characters
  • Reviewed and removed some #if 0 sections
  • Misc minor improvements
  • (re)ran clang-format
  • Updated release version to 1.0.44

- Minimum requirement now C++14, supports C++17
- added `adobe::invoke_result_t` to polyfill C++17
- added `adobe::construct_at()` to polyfill C++20
- deprecated `adobe::construct()` -> use `adobe::construct_at()`
- Removed `std::binary_operation` and `std::unary_operation`
- Updated to boost 1.76.0
- Fixed section divider comments to all be 100 characters
- Reviewed and removed some #if 0 sections
- Misc minor improvements
- (re)ran clang-format
- Updated release version to 1.0.44
@sean-parent sean-parent self-assigned this May 11, 2021
adobe/forest.hpp Outdated Show resolved Hide resolved
Copy link
Member

@fosterbrereton fosterbrereton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from one possible bug, LGTM!

Fixing bug with reverse_fullorder_iterator copies.

Co-authored-by: Foster Brereton <fbrereto@adobe.com>
@sean-parent
Copy link
Member Author

I'm going to push this and open an issue to add the stlab dependency (already implicit for copy_on_write but not needed for building tests).

@sean-parent sean-parent merged commit b71f5d0 into master May 12, 2021
@sean-parent sean-parent deleted the sparent/cpp17 branch January 13, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants