Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove comment after clarification and add test case for this. #99

Merged
merged 1 commit into from
Nov 14, 2017
Merged

Remove comment after clarification and add test case for this. #99

merged 1 commit into from
Nov 14, 2017

Conversation

FelixPetriconi
Copy link
Member

Fix issue #18

@codecov
Copy link

codecov bot commented Nov 12, 2017

Codecov Report

Merging #99 into develop will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #99      +/-   ##
===========================================
+ Coverage    94.85%   94.91%   +0.06%     
===========================================
  Files           36       36              
  Lines         4530     4545      +15     
  Branches       222      222              
===========================================
+ Hits          4297     4314      +17     
+ Misses          90       88       -2     
  Partials       143      143
Impacted Files Coverage Δ
stlab/concurrency/future.hpp 87.94% <ø> (+0.62%) ⬆️
test/future_tests.cpp 98.19% <ø> (-0.49%) ⬇️
test/future_then_tests.cpp 99.19% <0%> (-0.27%) ⬇️
test/channel_test_helper.hpp 93.75% <0%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73d98ae...8963117. Read the comment docs.

@FelixPetriconi FelixPetriconi merged commit 6ad2c41 into stlab:develop Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant