Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring Junit tests to Java 1.6 compatibility #539

Merged
merged 1 commit into from
Jul 24, 2020
Merged

Conversation

stleary
Copy link
Owner

@stleary stleary commented Jul 18, 2020

What problem does this code solve?
The project code is 1.6-compatible, but the unit tests require Java 1.7. This makes building and testing clumsy, and
can't be sure the lib works correctly in a Jave 1.6 environment. Remove diamond operators: <> and
autoclose expressions from several junit modules. Updated Maven pom.xml to use Java 1.6.
Confirmed that Maven (1.6) and Gradlew (1.8) build and test correctly.

Risks
No risk to production code, moderate risk to unit tests.

Changes to the API?
No

Will this require a new release?
No

Should the documentation be updated?
Yes - readme will need to be updated, but it's currently in review on another branch.
CI build will be updated on approval/merge, to add testing to the 1.6 build.

Does it break the unit tests?
No

Was any code refactored in this commit?
No

Review status
Approved - by myself

@stleary
Copy link
Owner Author

stleary commented Jul 21, 2020

Starting 3-day comment window.

@stleary stleary merged commit 0e34d8d into master Jul 24, 2020
This was referenced Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant