Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close XML tag explicitly for empty tags with configuration. #820

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Close XML tag explicitly for empty tags with configuration. #820

merged 4 commits into from
Oct 31, 2023

Conversation

rudrajyotib
Copy link
Contributor

Added configuration option - closeEmptyTag
When this flag is set to true, all the empty tags will be closed using explicit start and end tag.

@rudrajyotib
Copy link
Contributor Author

@stleary - mvn:test is failing for java 11 execution, which seems to be a one-off and temporary problem. Can the CI steps be executed once more please. I have run the tests locally with Java versions 8, 11, 17 and they do not fail. I think another run should mark it clear, if not, I will look into it.

@stleary
Copy link
Owner

stleary commented Oct 27, 2023 •
edited
Loading

Fixes #748

@rudrajyotib Looks good, just one comment to address.

@rudrajyotib
Copy link
Contributor Author

@stleary - updated configuration builder and added test cases.

@stleary stleary changed the title #748 - close XML tag explicitly for empty tags with configuration. Close XML tag explicitly for empty tags with configuration. Oct 28, 2023
@stleary
Copy link
Owner

stleary commented Oct 28, 2023

What problem does this code solve?
Fixes a request made to support optional alternate XML close tags

Does the code still compile with Java6?
Yes

Risks
Low

Changes to the API?
Adds a new XMLParserConfiguration property

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No, new unit tests were added

Was any code refactored in this commit?
No

Review status
APPROVED

Starting 3-day comment window

@stleary stleary mentioned this pull request Oct 28, 2023
Closed
@stleary stleary merged commit 6c1bc06 into stleary:master Oct 31, 2023
7 checks passed
@rudrajyotib rudrajyotib deleted the issue748 branch November 1, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stleary stleary stleary approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rudrajyotib @stleary