-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add get_all_symbols function #155
Conversation
Pull Request Test Coverage Report for Build 462
💛 - Coveralls |
Pull Request Test Coverage Report for Build 453
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I find this to be a useful feature. So far it looks good for me. Please have a look at my review for minor change requests. Of course there also need to be some tests and documentation for the new feature. Would you like to take care of these, too?
@@ -32,6 +32,7 @@ | |||
PLCTYPE_DT, | |||
PLCTYPE_DWORD, | |||
PLCTYPE_INT, | |||
PLCTYPE_LINT, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that this was missing from the imports. Not strictly needed for this PR, so I can remove it from here if you'd prefer it in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind. This is just a small import. No need to make a separate PR for it.
Thanks for taking a look, I've addressed your comments and added some tests and some documentation to the quickstart guide. Regarding the import re-ordering, let me know if you'd prefer me to open a separate PR for reordering imports or if you'd like to leave it as is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Would you mind adding an entry to the Changelog. Then the PR is ready to merge.
Thanks for taking a look. I'm not able to merge, so feel free to do so yourself when you get a chance. |
Thanks @chrisjbremner for the great work 👍 |
this is a great contribution!!!! |
@stlehmann could I request a new release that incorporates this addition? |
@chrisjbremner Yes, I think now is a good time for a new major release. I will get to it. |
Release 3.3.0 is out. |
I was looking for a way to retrieve all symbol information and came across #124, indicating this was not a feature. I searched the ADS repo for
AdsReadSymbolInfo
which #124 implies exists, but I could not find it.The ability to read symbols was a feature I had used before in the
counsyl-pyads
package, so I decided to port over the logic. There's also logic in that package that allows you to read a symbol by name, but I decided against adding that for now unless there's a request to do so.Here's a sample when tested with a PLC running TC3:
You may also notice that the import ordering was slightly modified to be in alphabetical order by
isort
. If this is not a desired change, I can revert it.