Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed duplicate tests and added addtional asserts to existing tests #209

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

chrisbeardy
Copy link
Collaborator

removed some duplicate tests. read/write_list_sub_commands had their tests duplicaed, possibly casused by merge of last PR. Also added more test crtieria for the no cache tests on rad and write_list_by_name to make sure that the symbol is not cached.

…et_list tests

removed some duplicate tests, possibly casuded by merge of last PR. Also addedmore test crtieria for the no cache tests to make sure that the symbol is not cached.
@coveralls
Copy link

coveralls commented Feb 17, 2021

Pull Request Test Coverage Report for Build 636

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.505%

Totals Coverage Status
Change from base Build 634: 0.0%
Covered Lines: 1135
Relevant Lines: 1201

💛 - Coveralls

Copy link
Owner

@stlehmann stlehmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. Seems the rebase was not a good idea alltogether. I'll be more careful with that in the future.

@stlehmann stlehmann merged commit 9892c67 into stlehmann:master Feb 18, 2021
@chrisbeardy chrisbeardy deleted the more_tests branch February 18, 2021 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants