Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor testserver into multiple files #243

Merged
merged 8 commits into from
May 12, 2021
Merged

Conversation

stlehmann
Copy link
Owner

@stlehmann stlehmann commented May 12, 2021

This PR basically rebases #237 to master and fixes issues with coveralls.

@stlehmann stlehmann marked this pull request as ready for review May 12, 2021 16:47
@coveralls
Copy link

coveralls commented May 12, 2021

Pull Request Test Coverage Report for Build 836422268

  • 376 of 414 (90.82%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.0%) to 93.69%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pyads/testserver/handler.py 18 19 94.74%
pyads/testserver/basic_handler.py 80 87 91.95%
pyads/testserver/advanced_handler.py 164 176 93.18%
pyads/testserver/testserver.py 110 128 85.94%
Totals Coverage Status
Change from base Build 775279533: -1.0%
Covered Lines: 1559
Relevant Lines: 1664

💛 - Coveralls

@stlehmann
Copy link
Owner Author

Thanks @RobertoRoos for this PR. I made some small changes regarding the whereabouts of the tests. I placed your additional tests for the AdvancedHandler in test_connection_class.py which is where also the tests for the BasicHandler live. I also removed the # pragma statements which eventually results in a lower coverage. But I don't mind that as long as we know where it comes from. Also we can improve coverage by time 😉

@stlehmann stlehmann merged commit a0c54f9 into master May 12, 2021
@stlehmann stlehmann deleted the testserver-package branch May 13, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants