Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the comment of a symbol is not encoded in utf-8 but in windows-1252.
I could not find it in the documentation of TwinCAT, but tested it on a Windows 10 machine with TwinCAT3.
It also matches the encoding used here:
pyads/pyads/utils.py
Line 56 in fc7733d
The other strings that are decoded with the
_get_string
method must be ASCII, which is compatible, so changing this here should not be an issue.