Added TWINCATSDK environment variable to resolve Windows TcAdsll.dll #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, i be been meaning to do this! Shall merge shortly |
|
Are you planing to merge this? We were planing to do it by ourselves otherwise. Thanks! |
|
Yes work is planned next week to merge a few things and release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows 11, for TwinCAT 4026.5, it seems TcAdsDll.dll has moved and we can not rely on TWINCAT3DIR. I have added to the resolution method to first search for a different variable TWINCATSDK, which seems to be the basis for the correct DLL. I've tested this on two separate systems.