Skip to content

Commit

Permalink
Add win32 travis build (#2)
Browse files Browse the repository at this point in the history
* add mingw64 build to travis CI

* Make .travis-lin-mingw.sh executable

* .travis-lin-mingw.sh: make build dir

* show $PWD in travis-lin-mingw

* update .travis-lin-mingw.sh

* ---

* update .travis-lin-mingw.sh

* update p7zip cmd

* fix sign/unsign comparioson in usb.c

* revert call .travis.sh

* clean up .travis-lin-mingw.sh
  • Loading branch information
slyshykO committed Feb 29, 2020
1 parent 43def93 commit 83a31a0
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 2 deletions.
14 changes: 14 additions & 0 deletions .travis-lin-mingw.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
#!/bin/bash

DIR=$PWD

if [ "$TRAVIS_OS_NAME" == "linux" ]; then
echo "WORK DIR:$DIR"
mkdir -p $DIR/build/linux-mingw32-release
cd $DIR/build/linux-mingw32-release
echo "cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_TOOLCHAIN_FILE=./cmake/linux-mingw32.cmake -DCMAKE_INSTALL_PREFIX=$PWD/_install $DIR"
cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_TOOLCHAIN_FILE=./cmake/linux-mingw32.cmake -DCMAKE_INSTALL_PREFIX=$PWD/_install $DIR
echo "make"
make
fi

This comment has been minimized.

Copy link
@Nightwalker-87

Nightwalker-87 Apr 8, 2020

Member

This script causes travis CI to fail on linux builds:

The command "./.travis-lin-mingw.sh" exited with 2.

This comment has been minimized.

Copy link
@slyshykO

slyshykO Apr 9, 2020

Author Collaborator

this is because you deleted important part of FindLibUsb and now libusb not detected for win32 target.

https://github.com/stlink-org/stlink/blob/master/cmake/modules/FindLibUSB.cmake#L99

Should I restore it ?

This comment has been minimized.

Copy link
@Nightwalker-87

Nightwalker-87 Apr 9, 2020

Member

No, it's ok for now, I added the script to gitignore.
That codeblock you marked did not vanish, it only moved within the file. Thus it should be called as expected.
I'll look at this soon.

This comment has been minimized.

Copy link
@slyshykO

slyshykO Apr 9, 2020

Author Collaborator

That codeblock you marked did not vanish,

Block was removed from his place. This cause error of libusb detection.

So I ask you to revert this a8c1f41 commit.

This comment has been minimized.

Copy link
@Nightwalker-87

Nightwalker-87 Apr 12, 2020

Member

This functionality is going to return with an upcoming PR for v1.6.1 after a refactoring of cmake routines.

3 changes: 3 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,12 @@ addons:
- g++-6
- gcc-6
- libusb-1.0.0-dev
- p7zip
- mingw-w64

script:
- git fetch --tags
- printenv
- cmake --version
- ./.travis.sh
- ./.travis-lin-mingw.sh
3 changes: 2 additions & 1 deletion cmake/modules/FindLibUSB.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@ if(NOT LIBUSB_FOUND)
file(MAKE_DIRECTORY ${LIBUSB_WIN_OUTPUT_FOLDER})

if(${ZIP_EXECUTABLE} MATCHES "p7zip")
execute_process(COMMAND ${ZIP_EXECUTABLE} -d --keep -f ${LIBUSB_WIN_ARCHIVE_PATH} WORKING_DIRECTORY ${LIBUSB_WIN_OUTPUT_FOLDER})
#execute_process(COMMAND ${ZIP_EXECUTABLE} -d --keep -f ${LIBUSB_WIN_ARCHIVE_PATH} WORKING_DIRECTORY ${LIBUSB_WIN_OUTPUT_FOLDER})
execute_process(COMMAND ${ZIP_EXECUTABLE} -d ${LIBUSB_WIN_ARCHIVE_PATH} WORKING_DIRECTORY ${LIBUSB_WIN_OUTPUT_FOLDER})
else()
execute_process(COMMAND ${ZIP_EXECUTABLE} x -y ${LIBUSB_WIN_ARCHIVE_PATH} -o${LIBUSB_WIN_OUTPUT_FOLDER})
endif()
Expand Down
2 changes: 1 addition & 1 deletion src/usb.c
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ int _stlink_usb_version(stlink_t *sl) {
cmd[i++] = STLINK_APIV3_GET_VERSION_EX;

size = send_recv(slu, 1, cmd, slu->cmd_len, data, rep_len);
if (size != rep_len) {
if (size != (ssize_t)rep_len) {
printf("[!] send_recv STLINK_APIV3_GET_VERSION_EX\n");
return (int) size;
}
Expand Down

0 comments on commit 83a31a0

Please sign in to comment.