Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for mass erasing second bank on STM32F10x_XL #767

Closed
bmellstrom opened this issue Feb 7, 2019 · 2 comments · Fixed by #768
Closed

Add support for mass erasing second bank on STM32F10x_XL #767

bmellstrom opened this issue Feb 7, 2019 · 2 comments · Fixed by #768
Assignees
@bmellstrom
Labels
code/feature-request status/resolved target/stm32f1
Milestone
v1.6.0

Comments

@bmellstrom
Copy link
Contributor

I added support for bank 2 on STM32F10x_XL a few years ago but apparently forgot to implement mass erase for it. The commit below fixes that:

bmellstrom@5212937

Shall I open a pull request?
@xor-gate
Copy link
Member

xor-gate commented Feb 7, 2019 via email

bmellstrom added a commit to bmellstrom/stlink that referenced this issue Feb 7, 2019
@bmellstrom
Add support for mass erasing second bank on STM32F10x_XL (stlink-org#767
ed430ff 
)
xor-gate pushed a commit that referenced this issue Feb 9, 2019
@bmellstrom @xor-gate
Add support for mass erasing second bank on STM32F10x_XL (#767)
8186d85
@xor-gate xor-gate added this to the Next milestone Feb 9, 2019
@xor-gate xor-gate changed the title Add support for mass erasing second bank on STM32F10x_XL (patch) Add support for mass erasing second bank on STM32F10x_XL Feb 9, 2019
@xor-gate xor-gate closed this as completed Feb 9, 2019
@xor-gate
Copy link
Member

xor-gate commented Feb 9, 2019

Thanks!

@Nightwalker-87 Nightwalker-87 removed this from the General milestone Feb 21, 2020
@Nightwalker-87 Nightwalker-87 self-assigned this Feb 21, 2020
@Nightwalker-87 Nightwalker-87 added this to the v1.6.0 milestone Feb 21, 2020
@Nightwalker-87 Nightwalker-87 linked a pull request Mar 20, 2020 that will close this issue
Add support for mass erasing second bank on STM32F10x_XL (#767) #768
Merged
@Nightwalker-87 Nightwalker-87 mentioned this issue Mar 29, 2020
Closed
6 tasks
@stlink-org stlink-org locked as resolved and limited conversation to collaborators Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bmellstrom bmellstrom

Labels
code/feature-request status/resolved target/stm32f1
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging a pull request may close this issue.

Add support for mass erasing second bank on STM32F10x_XL (#767) bmellstrom/stlink
3 participants
@xor-gate @bmellstrom @Nightwalker-87