Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vl flashloader for all STM32F1 series #1042

Closed
wants to merge 32 commits into from
Closed

Use vl flashloader for all STM32F1 series #1042

wants to merge 32 commits into from

Conversation

Ant-ON
Copy link
Collaborator

@Ant-ON Ant-ON commented Sep 26, 2020

stlink_write_flash should use the flashloader for all chip of F1 series. But there are problems in stlink_flash_loader_write_to_sram. Not all chip IDs are associated with the flashloader. It fixes issue #1041.

chenguokai and others added 30 commits May 18, 2020 00:36
[bugfix] Connect under reset for st-flash and st-util
- Add halt callback to backend.
- Add speed option to set COM speed.
- Fix register get issue.
Issues: going into debug mode not working
ASCII format used for stings.
ASCII format used for stings.
Added support for STM32L5x2 series.
Merge branch 'connect_under_reset' into 'nightly'.
@Nightwalker-87 Nightwalker-87 changed the title Using vl flashoader with all F1 series Use vl flashloader for all STMF1 series Sep 26, 2020
@Nightwalker-87 Nightwalker-87 changed the base branch from nightly to develop September 26, 2020 17:40
@Nightwalker-87
Copy link
Member

Nightwalker-87 commented Sep 26, 2020

@Ant-ON: Can you please rebase this PR to the develop branch without closing and reopening it.
There are various problems in the nightly tree which need to be fixed. We don't want these in our development tree.
I advise to stay on develop for now.

@Ant-ON
Copy link
Collaborator Author

Ant-ON commented Sep 29, 2020

@Nightwalker-87, I cannot find how to move/rebase a commit from one branch to another. It can only be copied ...
ps The night tree has some useful patches, but a bit of garbage

@stappersg
Copy link
Contributor

stappersg commented Sep 29, 2020 via email

@Nightwalker-87
Copy link
Member

Nightwalker-87 commented Sep 29, 2020

@Ant-ON: I know - that's why I don't want it to be merged into develop. Instead I'll do some local maintenance on it.

@Nightwalker-87
Copy link
Member

Nightwalker-87 commented Oct 1, 2020

@Ant-ON: Try this: https://stackoverflow.com/questions/44664830/how-can-you-change-the-branch-on-a-pr

I just figured out, that they close/delete the original PR as well. 😕
Never mind, just open a new one then.
I noticed you have pulled a clean copy of "develop" in the meanwhile and committed the desired change.

@Ant-ON
Copy link
Collaborator Author

Ant-ON commented Oct 2, 2020

@Nightwalker-87
Yes, but I have not found how to change the current PR.
I realized that this is not possible.

@Ant-ON Ant-ON closed this Oct 2, 2020
@Nightwalker-87 Nightwalker-87 changed the title Use vl flashloader for all STMF1 series Use vl flashloader for all STM32F1 series Oct 2, 2020
@Nightwalker-87
Copy link
Member

@Ant-ON: I recommend you to delete this nightly branch on your fork as well as it fails completely on our automated build tests (which I noticed too late). Some merges to that branch did mix up destructively and it appears too complicated to unwind the issues again.

@Ant-ON
Copy link
Collaborator Author

Ant-ON commented Oct 19, 2020

@Nightwalker-87 I removed this branch from my fork

@stlink-org stlink-org locked as resolved and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants