st-flash: respect --connect-under-reset option #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you verify that this closes some related issues to |
|
That looks correct to me. It looks like the necessary bit of code at the
USB open didn't get committed previously
Geoffrey
…On Sat, Oct 17, 2020 at 11:30 AM nightwalker-87 ***@***.***> wrote:
Can you verify that this closes some related issues to
--connect-under-reset ? There were some previous approaches to address
this issue already. It would be good to know why they obviously failed.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1051 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANL6USP5JGLPASDRVTCGGDSLG2APANCNFSM4SQM2EIA>
.
|
|
So the reason for this patch, is that I'm reviving the patches from #1033 to add STM32H7 support. What I have found is that unless I connect to the target board under reset, the chip ID would be read back incorrectly. I cannot comment on other STM32 targets. |
|
@timothytylee: Thx for the feedback. Maybe someone else can look at it with the focus on some other targets as well. Thus I'll leave this PR open to feedback for another few days. |
Nightwalker-87
approved these changes
Oct 18, 2020
chenguokai
approved these changes
Oct 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --connect-under-reset option is already parsed by src/st-flash/flash_opts.c. Respect this option when opening the USB connection.