-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] ITM functionality for ST-Link V2 and STM32Fxx chipsets #1072
Conversation
Adding calls to identify st-links.
Adding a log macro. Adding logs with stlink list.
…art trace method.
Improved comments.
…e the configuration and to tell the user what to do if it is not configured.
…isplays a diagnositic message if it looks like we are not configured correctly.
… correctly in some scripts.
Fixing buffer semantics.
@Nightwalker-87 I will squash all commits into a single commit after all CR feedback has been implemented. |
I had added the max_trace_freq field to the stlink structure in the middle. I've corrected that by moving it to the end. |
@Nightwalker-87, this PR looks good to me. |
@slyshykO It still fails: https://travis-ci.org/github/stlink-org/stlink/builds/748613319 |
@Nightwalker-87 think it is time for Github Actions |
@Nightwalker-87 Sorry I was waiting for additional code review feedback and had not squashed all commits into a single commit yet. It also looks like I broke the build in clang by mixing a 64 bit size_t type and a 32 bit int type. I will work on fixing this now and get clang installed to verify the results. |
... he seems to collect everything up, involuntarily 🤣 |
At least the recent custom triggered build of the |
@Nightwalker-87 Travis CI has changed its pricing model. |
I know, but it is still free for OSS-Projects, so we don't pay anything for it. |
Free, but more limited than before. Looks like we encounter those limits. |
I'll have an eye on it. Should we run into further problems, one may think about appropriate alternatives. |
This change implements feature #136.
The main changes:
I did bench testing while developing this, including testing with incorrect clock speeds and with overruns. However, this testing has been done with an extremely limited number of only STM32F4 processors. I could use some help running this on a wider variety of hardware. I am currently using st-trace in a production environment that automatically runs test suites on multiple hardware devices.
This code review is larger than I would hope for my first to this project. I've tried to make the code fit in with the project, but please don't hold back if I've missed the mark anywhere.
Thanks,
John