Flash loader rework #1113
Merged
Flash loader rework #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should give @chenguokai the chance to review as well, because he did the last major rewrite of the flash-loader stuff. |
This was referenced Mar 23, 2021
chenguokai
approved these changes
Mar 24, 2021
Nightwalker-87
approved these changes
Mar 24, 2021
This was referenced Mar 24, 2021
6 tasks
|
@Ant-ON Thank you very much for this very important work! 🚀 |
This was
linked to
issues
Apr 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, the waiting for data writing is changed from cycles to ms. This should be a more robust solution.
Fixed a flash loader bug. The flash loader had an incorrect busy wait cycle. The use of bootloader argument registers during boot removed. Removed magic with recalculation of the
sizeto thecount. The number of bytes to load (size) is transferred to the flash loader now.Added disabling of interrupts during flash loader execution. In some cases interrupts caused a failure
(Closes #356, Closes #556, Closes #593, Closes #597, Closes #607, Closes #612, Closes #638, Closes #661, Closes #690, Closes #817, Closes #818, Closes #854, Closes #967, Closes #979, Closes #1043, Closes #1054, Closes #1092, Closes #1105, Closes #1113)
(Partially fixes #724, Partially fixes #868, Partially fixes #1008)