Updated chip config files from the library structs #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Some? All?) CI failures seem unrelated: |
|
Need to check, likely to be unrelated to the content indeed... |
Nightwalker-87
approved these changes
Aug 21, 2021
|
It's obviously a temporary bug in the respective GitHub Actions Build Environment - we should wait for it to be fixed before merging. |
|
It seems to be this issue (apparently an evergreen): actions/runner-images#675 |
6 tasks
|
@gszy The latest commit fixes the issue within the GH Actions workflow routine. |
Nightwalker-87
force-pushed
the
develop
branch
from
a6cb2fd
to
c8fc656
Compare
In general, the chip config files should be kept in sync with the old library structs. Regenerate the files (using an ad hoc script) from the current library. The file name is generated from the chip description, all non-alphanumeric characters are replaced with underscores. It turns out some files have to have their names changed.
|
@Nightwalker-87, done. I think this commit, if merged, should be followed by a commit that would remove the old library struct completely. |
Nightwalker-87
changed the title
|
@gszy Thank you so much! 🥇 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, the chip config files should be kept in sync with the old
library structs. Regenerate the files (using an ad hoc script) from the
current library.
The file name is generated from the chip description, all
non-alphanumeric characters are replaced with underscores. It turns out
some files have to have their names changed.
See #1180 (comment) and #1180 (comment).