Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed compliation for OpenBSD 7.0 #1202

Merged
merged 2 commits into from
Dec 1, 2021
Merged

Conversation

Crest
Copy link
Contributor

@Crest Crest commented Nov 24, 2021

On OpenBSD libusb is provided by the libusb1 port and the existing Findlibusb.cmake module failed to detect it properly because it installs to /usr/local in accordance with the OpenBSD filesystem hierarchy. Teaching cmake the OpenBSD file system layout gets us half the way.

The second and last problem I've encountered is that the MINIMAL_API_VERSION required under OpenBSD is undeclared causing a compile error in libusb_settings.h. I used libusb 1.0.23p2 installed from the official binary package repository, but I don't see any reasons why OpenBSD should require a newer libusb version than other platforms.

On OpenBSD libusb is provided by the libusb1 port/package.
Every platform has to declare the minimum libusb API level
required by libstlink on it.
@Nightwalker-87 Nightwalker-87 changed the title Allow stlink to build on OpenBSD 7.0 Fixed compliation for OpenBSD 7.0 Nov 28, 2021
@Nightwalker-87 Nightwalker-87 added this to the v1.7.1 milestone Nov 28, 2021
@Nightwalker-87 Nightwalker-87 merged commit cb0f91a into stlink-org:develop Dec 1, 2021
@nbonfils
Copy link

I hope it's not to out of topic, but I've been so frustrated with AVR related things on OpenBSD, the fact that stlink built out of the box without needing to touch anything was so relieving. Literally made my whole weekend better!
I take it's thanks to @Crest and also to the stlink-org team (@Nightwalker-87 and @xor-gate it seems) to have made a software that's not unfriendly to the "fringe" OSes.
Thank you <3

@Nightwalker-87
Copy link
Member

Nightwalker-87 commented Dec 11, 2021

@nbonfils Thank you very much. It is good to hear such feedback from affected users.
It is indeed a key objective of this toolset to maintain best possible support for a wide range of operating environments (as a far as we can sustain compatibility regarding libraries and packages). As it appears we are on a good way here... 😃

May I include your review on our main page to give additional orientation to new users? Please let me know.

@nbonfils
Copy link

Of course @Nightwalker-87, feel free to do so.
This key objective definitely deserves more appreciation. It might even be worth mentioning in the README as this sort of details usually hints users like me that this software and the maintainers care. We totally need more of that.
Thank you again.

@stlink-org stlink-org locked as resolved and limited conversation to collaborators Jan 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants