Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactoring] sourcefile 'common.c' #1220

Conversation

hydroconstructor
Copy link
Collaborator

@hydroconstructor hydroconstructor commented Jan 28, 2022

Files updated according to changes made in chipid_cleanup. Compilable in Windows and Ubuntu. But there is still conflict with common.c, which I try ty refactor. Tomorrow will work with it.

@Nightwalker-87
Copy link
Member

Nightwalker-87 commented Jan 28, 2022

@hydroconstructor Please stay with #1218 first. There was no technical need actually to open another PR for the same topic.

Edit: Now with #1218 updated to resolve conflicts, it has now been successfully merged. Thus the task is to identify the delta of this PR related to develop.

@Nightwalker-87
Copy link
Member

@hydroconstructor After some manual clean-up you may now continue to contribute here.

@Nightwalker-87 Nightwalker-87 removed the request for review from gszy February 4, 2022 18:32
@Nightwalker-87 Nightwalker-87 changed the title Chipid cleanup common c refactor [refactoring] sourcefile 'common.c' Feb 4, 2022
@Nightwalker-87 Nightwalker-87 merged commit 924e1ec into stlink-org:develop Feb 4, 2022
@stlink-org stlink-org locked as resolved and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants