Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General fixes and improvements #1295

Merged
merged 8 commits into from
Feb 14, 2023
Merged

General fixes and improvements #1295

merged 8 commits into from
Feb 14, 2023

Conversation

Nightwalker-87
Copy link
Member

@Nightwalker-87 Nightwalker-87 commented Jan 8, 2023

General fixes and improvements

- Removed orphaned old dev-documentation
- Rearranged src files belonging to stlink-lib
- Revised & sorted option byte source code
- Updated devices_boards.md
- Bugfix: "Failed to parse flash type or unrecognized flash type"
(Closes #1240) (Closes #1242) (Closes #1290) (Closes #1291)
- Updated README.md on OS-support
- Updated version_support.md
- Removed remnants of macOS support in CMakeLists.txt
- Minor code formatting fixes
- Updated CHANGELOG.md
@Nightwalker-87
Copy link
Member Author

Waiting for Reviews here in order to proceed.

@slyshykO
Copy link
Collaborator

slyshykO commented Jan 15, 2023

There is an incorrect md5 sum for libusb in Findlibusb.cmake.
So, on win32 project is not resolved.

Valid md5 is aabe177bde869bfad34278335eaf8955

@Nightwalker-87
Copy link
Member Author

@slyshykO Thank you so much for your review. I'll check ASAP. If interested, you may also take a look at some other issues.

@Nightwalker-87 Nightwalker-87 requested review from hydroconstructor and removed request for Ant-ON January 28, 2023 20:19
@Nightwalker-87 Nightwalker-87 removed the request for review from gszy February 11, 2023 14:15
@Nightwalker-87 Nightwalker-87 removed the request for review from hydroconstructor February 11, 2023 14:15
@Nightwalker-87
Copy link
Member Author

Ping @simplerobot: Any further remarks?

Copy link
Collaborator

@simplerobot simplerobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me.

src/stlink-lib/chipid.c Outdated Show resolved Hide resolved
- Updated Standards-Version for deb-package
- Fix for strcmp(value, "L4") in chipid.c
- Minor formatting fixes
@Nightwalker-87 Nightwalker-87 merged commit c721751 into develop Feb 14, 2023
@Nightwalker-87
Copy link
Member Author

Thanks again for looking at this. 👍

@stlink-org stlink-org locked as resolved and limited conversation to collaborators Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.